[PATCH] D14290: compiler-rt: add make solution to bootstrap for mingw-w64

[Saleem Abdulrasool via llvm-commits]

compnerd added inline comments.

================
Comment at: make/platform/clang_mingw.mk:6
@@ +5,3 @@
+CC := clang
+AR := llvm-ar
+
----------------
What happens when llvm-ar is not found?  I don't think using llvm-ar since we can't bootstrap that.  It should use ar.

================
Comment at: make/platform/clang_mingw.mk:23
@@ +22,3 @@
+CFLAGS.builtins-i386 := -target i686-windows-gnu $(CFLAGS) -rtlib=compiler-rt -m32
+CFLAGS.builtins-arm := -target armv7-windows-gnu $(CFLAGS) -rtlib=compiler-rt -m32
+
----------------
The `-rtlib` flags here are irrelevant.  The builtins are static libraries, no link will be performed.  `-m32` on ARM is incorrect.  There is no 32-bit or 64-bit there.  64-bit ARM is armv8, not armv7.

================
Comment at: make/platform/clang_mingw.mk:33
@@ +32,3 @@
+
+# We don't need to use visibility hidden on Linux.
+VISIBILITY_HIDDEN := 0
----------------
This isn't Linux :-).

================
Comment at: make/platform/clang_mingw.mk:36
@@ +35,2 @@
+
+SHARED_LIBRARY_SUFFIX := a
----------------
This shouldn't be needed since no shared libraries will be created.


http://reviews.llvm.org/D14290