[PATCH] D14304: [IR] add bounds checking to paramHasAttr

Eli Friedman via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 3 20:28:16 PST 2015


eli.friedman added a comment.

The FastIsel changes appear to be correct... but probably not the most clear way to write it.  It would be better to combine the if statements so it only checks `arg_size != 0` once.

Granted, I'm just basing that assessment off of r160725.  If I did have any special knowledge here, I've forgotten it.


http://reviews.llvm.org/D14304





More information about the llvm-commits mailing list