[PATCH] D14310: [LLD] Fix Clang-tidy modernize-use-override warnings, other minor fixes

Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 3 18:14:20 PST 2015


This revision was automatically updated to reflect the committed changes.
Closed by commit rL252034: Fix Clang-tidy modernize-use-override warnings, other minor fixes. (authored by eugenezelenko).

Changed prior to commit:
  http://reviews.llvm.org/D14310?vs=39133&id=39142#toc

Repository:
  rL LLVM

http://reviews.llvm.org/D14310

Files:
  lld/trunk/ELF/OutputSections.h
  lld/trunk/lib/ReaderWriter/MachO/SectCreateFile.h

Index: lld/trunk/lib/ReaderWriter/MachO/SectCreateFile.h
===================================================================
--- lld/trunk/lib/ReaderWriter/MachO/SectCreateFile.h
+++ lld/trunk/lib/ReaderWriter/MachO/SectCreateFile.h
@@ -23,7 +23,6 @@
 //
 class SectCreateFile : public File {
 public:
-
   class SectCreateAtom : public SimpleDefinedAtom {
   public:
     SectCreateAtom(const File &file, StringRef segName, StringRef sectName,
@@ -68,19 +67,19 @@
       new (allocator()) SectCreateAtom(*this, seg, sect, std::move(content)));
   }
 
-  const AtomVector<DefinedAtom> &defined() const {
+  const AtomVector<DefinedAtom> &defined() const override {
     return _definedAtoms;
   }
 
-  const AtomVector<UndefinedAtom> &undefined() const {
+  const AtomVector<UndefinedAtom> &undefined() const override {
     return _noUndefinedAtoms;
   }
 
-  const AtomVector<SharedLibraryAtom> &sharedLibrary() const {
+  const AtomVector<SharedLibraryAtom> &sharedLibrary() const override {
     return _noSharedLibraryAtoms;
   }
 
-  const AtomVector<AbsoluteAtom> &absolute() const {
+  const AtomVector<AbsoluteAtom> &absolute() const override {
     return _noAbsoluteAtoms;
   }
 
Index: lld/trunk/ELF/OutputSections.h
===================================================================
--- lld/trunk/ELF/OutputSections.h
+++ lld/trunk/ELF/OutputSections.h
@@ -251,7 +251,7 @@
 class InterpSection final : public OutputSectionBase<ELFT> {
 public:
   InterpSection();
-  void writeTo(uint8_t *Buf);
+  void writeTo(uint8_t *Buf) override;
 };
 
 template <class ELFT>
@@ -392,6 +392,8 @@
 template <class ELFT> SymbolTableSection<ELFT> *Out<ELFT>::DynSymTab;
 template <class ELFT> SymbolTableSection<ELFT> *Out<ELFT>::SymTab;
 template <class ELFT> typename Out<ELFT>::uintX_t Out<ELFT>::TlsInitImageVA;
-}
-}
-#endif
+
+} // namespace elf2
+} // namespace lld
+
+#endif // LLD_ELF_OUTPUT_SECTIONS_H


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D14310.39142.patch
Type: text/x-patch
Size: 1911 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151104/31e371b8/attachment.bin>


More information about the llvm-commits mailing list