[PATCH] D14295: [WebAssembly] Support wasm select operator

Dan Gohman via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 3 14:22:23 PST 2015


sunfish accepted this revision.
sunfish added a comment.
This revision is now accepted and ready to land.

lgtm, with just one minor nit.


================
Comment at: test/CodeGen/WebAssembly/select.ll:9
@@ +8,3 @@
+
+;; CHECK-LABEL: select_i32:
+;; CHECK: get_local 1
----------------
As a minor nit, we only use a single semicolon for CHECK comments in LLVM IR in the other tests.


http://reviews.llvm.org/D14295





More information about the llvm-commits mailing list