[PATCH] D14301: [elf2] Implement R_X86_64_TPOFF32.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 3 12:46:15 PST 2015


ruiu added inline comments.

================
Comment at: ELF/OutputSections.h:356
@@ -355,3 +355,3 @@
 template <class ELFT> struct Out {
   static DynamicSection<ELFT> *Dynamic;
   static GnuHashTableSection<ELFT> *GnuHashTab;
----------------
Let's typedef uintX_t here to avoid line wrapping.

================
Comment at: ELF/OutputSections.h:374
@@ -373,1 +373,3 @@
+  static
+      typename llvm::object::ELFFile<ELFT>::uintX_t ThreadInitializationImageVA;
 };
----------------
This name is too long. How about TlsTemplateVA?


http://reviews.llvm.org/D14301





More information about the llvm-commits mailing list