[PATCH] D14278: Fix unit tests on Windows: handle env vars with non-ASCII chars.

[Paweł Bylica via llvm-commits]

chfast added inline comments.

================
Comment at: unittests/Support/ProgramTest.cpp:64
@@ +63,3 @@
+  // On Windows we have to take UTF16 encoded env vars and convert them to UTF8.
+  static std::vector<std::string> storage; // Helper storage for converted vars.
+  storage.clear();
----------------
yaron.keren wrote:
> Will this unit test never run multithreaded?
> 
That is the weak point. What do you think about extracting `storage` as a function argument?


Repository:
  rL LLVM

http://reviews.llvm.org/D14278