[PATCH] D14167: [lld][elf2] Generate PT_TLS.

[George Rimar via llvm-commits]

grimar added inline comments.

================
Comment at: ELF/Writer.cpp:674
@@ +673,3 @@
+  Elf_Phdr TlsPhdr;
+  TlsPhdr.p_vaddr = 0;
+  uintX_t ThreadBSSOffset = 0;
----------------
ruiu wrote:
> Bigcheese wrote:
> > ruiu wrote:
> > > Do we need this? Isn't an Elf_Phdr zero-initialized?
> > There's no explicit zero init, and I'm pretty sure default-initialization here does nothing.
> I'd zero out all fields using memset.
What about next ?

```
Elf_Phdr TlsPhdr = {};
```


Repository:
  rL LLVM

http://reviews.llvm.org/D14167