[PATCH] D14271: [CVP] Fold return values if possible

Philip Reames via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 2 18:13:20 PST 2015


reames added inline comments.

================
Comment at: lib/Transforms/Scalar/CorrelatedValuePropagation.cpp:339-340
@@ +338,4 @@
+  // at least the outer shims around such.
+  auto *C = dyn_cast<CmpInst>(V);
+  if (!C) return nullptr;
+
----------------
Do you have a particular pattern you'd want to handle?  My preference would be a) a follow on change and b) not doing this until I can get this pushed down into LVI.  (That's on my list, just need to clear some other LVI/CVP changes out first.)


http://reviews.llvm.org/D14271





More information about the llvm-commits mailing list