[PATCH] D13841: [CMake] Bug 25059 - CMake libllvm.so.$MAJOR.$MINOR shared object name not compatible with ldconfig

[Andrew Wilkins via llvm-commits]

axw added a subscriber: axw.

================
Comment at: cmake/modules/AddLLVM.cmake:546-548
@@ +545,5 @@
+      if(ARG_SHARED AND UNIX)
+        # Disable CMake's builtin SO versioning. Historically LLVM hasn't used so
+        # versioning on Darwin, and linux so versioning is hand-rolled.
+        set_target_properties(${name} PROPERTIES NO_SONAME On)
+        if(NOT APPLE)
----------------
Setting NO_SONAME means SONAME isn't set *at all*, which doesn't seem desirable.

    $ objdump -p lib/libLLVM-3.8.0svn.so  | grep -c SONAME
    0

That doesn't seem desirable. I would expect to see the SONAME set to the same as the output name. I think you just want to not set SOVERSION/VERSION instead? Did you mean to set NO_SONAME only for Apple?


http://reviews.llvm.org/D13841