[PATCH] D8841: [X86][XOP] Add support for the matching of the VPCMOV bit select instruction

Sanjay Patel via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 2 11:53:41 PST 2015


spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.

LGTM - see comment about potentially reducing the test overhead.


================
Comment at: test/CodeGen/X86/xop-pcmov.ll:2
@@ +1,3 @@
+; RUN: llc < %s -mtriple=x86_64-unknown-unknown -mattr=+avx,+xop | FileCheck %s
+; RUN: llc < %s -mtriple=x86_64-unknown-unknown -mattr=+avx2,+xop | FileCheck %s
+
----------------
Does the 'avx2' run exercise a different path through the code? If not, the plain 'avx' run should be sufficient by itself?


Repository:
  rL LLVM

http://reviews.llvm.org/D8841





More information about the llvm-commits mailing list