[PATCH] D13532: [CGP] widen switch condition and case constants to target's register width

Sanjay Patel via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 2 11:30:57 PST 2015


spatel marked an inline comment as done.
spatel added a comment.

In http://reviews.llvm.org/D13532#276839, @hfinkel wrote:

> Can you think of any way to have it pick sext instead of zext when we know the input is really sign extended anyway? This might only apply to function arguments?


Nice catch. I agree that we should sext instead of zext in that case. If it's only applicable to function args, it seems straightforward to add that check. New patch coming soon.


http://reviews.llvm.org/D13532





More information about the llvm-commits mailing list