[llvm] r251815 - MachO: improve load command tests slightly

Tim Northover via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 2 11:23:43 PST 2015


Hi Davide,

> I know very little about TvOS and WatchOS so I may miss something, but
> there's a real reason why you can't use llvm-readobj (as you did in
> the test above)?

Thanks for looking at the code! I could, but I think that doesn't
really add much benefit (llvm-readobj dumping is already tested, as
you noticed).

I'd prefer to implement support in llvm-objdump (it needs it anyway)
and enable these tests properly as part of that. I'm probably going to
do that later this afternoon, I'm really just making a first-pass
minimising diffs that crept in with our internal branch during the
initial commits at the moment.

Cheers.

Tim.


More information about the llvm-commits mailing list