[PATCH] D14244: [AArch64]Enable the narrow ld promotion only on profitable microarchitectures

Chad Rosier via llvm-commits llvm-commits at lists.llvm.org
Mon Nov 2 11:11:27 PST 2015


mcrosier accepted this revision.
mcrosier added a comment.
This revision is now accepted and ready to land.

LGTM.  Thanks, Jun.


================
Comment at: lib/Target/AArch64/AArch64LoadStoreOptimizer.cpp:1395
@@ -1381,2 +1394,3 @@
   bool Modified = false;
+  bool enableNarrowLdOpt = enableNarrowLdMerge(Fn);
   for (auto &MBB : Fn)
----------------
Jun and I discussed this offline.  We shouldn't sink this because we don't need to call this predicate for every function.  The answer will always be the same, so we only call it once in the runOnFunction function.


http://reviews.llvm.org/D14244





More information about the llvm-commits mailing list