[PATCH] D13257: [LAA] LLE 4/6: APIs to access the dependent instructions for a dependence, NFC

[hfinkel@anl.gov via llvm-commits]

hfinkel accepted this revision.
hfinkel added a comment.
This revision is now accepted and ready to land.

LGTM.

Maybe I'm overlooking some existing commentary, but we should do a better job of documenting what the source and destination mean where there are multiple possible sources and/or destinations of the same distance. To be clear about what I mean, if I take your example from http://reviews.llvm.org/D13254:

  for (unsigned i = 0; i < 100; i++) {
    A[i+8] = B[i] + 2;
    C[i] = A[i] * 2;
  }

and I do this:

  for (unsigned i = 0; i < 100; i++) {
    A[i+8] = B[i] + 2;
    A[i+8] = F[i] + 2;
    C[i] = A[i] * 2;
    D[i] = A[i] * 4;
  }

are there multiple distance-8 dependencies, or only one for A[i] <-> A[i+8], and if only one, to which A[i+8] store does it refer (the first or the second). I realize this is a bit silly here, because one of these stores is dead, but generally speaking, we should define how this is represented.


http://reviews.llvm.org/D13257