[PATCH] D14196: [ELF2] Ensure the DynSymTab to be finalized before the others

[Igor Kudrin via llvm-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rL251789: [ELF2] Ensure that .dynsym section is finalized before .gnu.hash. (authored by ikudrin).

Changed prior to commit:
  http://reviews.llvm.org/D14196?vs=38787&id=38883#toc

Repository:
  rL LLVM

http://reviews.llvm.org/D14196

Files:
  lld/trunk/ELF/OutputSections.cpp
  lld/trunk/ELF/Writer.cpp

Index: lld/trunk/ELF/Writer.cpp
===================================================================
--- lld/trunk/ELF/Writer.cpp
+++ lld/trunk/ELF/Writer.cpp
@@ -581,9 +581,13 @@
   for (OutputSectionBase<ELFT> *Sec : OutputSections)
     Out<ELFT>::ShStrTab->add(Sec->getName());
 
-  // Fill the DynStrTab early because Dynamic adds strings to
-  // DynStrTab but .dynstr may appear before .dynamic.
+  // Finalizers fix each section's size.
+  // .dynamic section's finalizer may add strings to .dynstr,
+  // so finalize that early.
+  // Likewise, .dynsym is finalized early since that may fill up .gnu.hash.
   Out<ELFT>::Dynamic->finalize();
+  if (isOutputDynamic())
+    Out<ELFT>::DynSymTab->finalize();
 
   // Fill other section headers.
   for (OutputSectionBase<ELFT> *Sec : OutputSections)
Index: lld/trunk/ELF/OutputSections.cpp
===================================================================
--- lld/trunk/ELF/OutputSections.cpp
+++ lld/trunk/ELF/OutputSections.cpp
@@ -340,8 +340,7 @@
 }
 
 template <class ELFT> void GnuHashTableSection<ELFT>::finalize() {
-  ArrayRef<SymbolBody *> A = Out<ELFT>::DynSymTab->getSymbols();
-  unsigned NumHashed = std::count_if(A.begin(), A.end(), includeInGnuHashTable);
+  unsigned NumHashed = HashedSymbols.size();
   NBuckets = calcNBuckets(NumHashed);
   MaskWords = calcMaskWords(NumHashed);
   // Second hash shift estimation: just predefined values.
@@ -900,6 +899,9 @@
 }
 
 template <class ELFT> void SymbolTableSection<ELFT>::finalize() {
+  if (this->Header.sh_size)
+    return; // Already finalized.
+
   this->Header.sh_size = getNumSymbols() * sizeof(Elf_Sym);
   this->Header.sh_link = StrTabSec.SectionIndex;
   this->Header.sh_info = NumLocals + 1;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D14196.38883.patch
Type: text/x-patch
Size: 1724 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151102/3b2dd6e9/attachment.bin>