[PATCH] D13801: [Support] Extend sys::path with user_cache_directory function.

Aaron Ballman via llvm-commits llvm-commits at lists.llvm.org
Sun Nov 1 14:39:07 PST 2015


aaron.ballman accepted this revision.
aaron.ballman added a comment.

LGTM with a testing request.


================
Comment at: unittests/Support/Path.cpp:340
@@ +339,3 @@
+    EXPECT_EQ("A", *++it);
+  }
+}
----------------
It would be nice to have a test that ensures non-ASCII characters in the path do not get corrupted. I don't think there's a reasonable way to test that for the user_cache_directory itself, but the paths we append would at least give some peace of mind.


http://reviews.llvm.org/D13801





More information about the llvm-commits mailing list