[lld] r251692 - Comments about how values were calculated for functions below were added.

Davide Italiano via llvm-commits llvm-commits at lists.llvm.org
Sat Oct 31 11:22:24 PDT 2015


On Sat, Oct 31, 2015 at 12:22 PM, Rui Ueyama via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
> I don't think this comments add much value to the code because it's already
> commented well. We have comments just above these new comments to show the
> final results of the calculations, so it is very easy to understand the
> intention of the code. If you get what we want to get here, it's in my
> opinion very easy to understand the code as well.
>

I don't personally mind them (in fact I requested for them, sorry) --
but if you feel like they should be removed, fine.
I don't think it's really worth the trouble of discussing further :)

Thanks,

--
Davide


More information about the llvm-commits mailing list