[llvm] r251664 - Revert "[ARM] Remove XFAIL on test/CodeGen/Generic/MachineBranchProb.ll"

[Eric Christopher via llvm-commits]

On Fri, Oct 30, 2015 at 10:19 AM Weiming Zhao <weimingz at codeaurora.org>
wrote:

> Yes, we should just use the revert function.
>
>
Yes.


> Is there any way to check a patch on buildbot before committing it?
>
>
Not at the moment, no.

-eric


> Currently, we're not sure why the check below fails on the buildbot:
> test/CodeGen/Generic/MachineBranchProb.ll:18:10: error: expected string
> not found in input
> ; CHECK: Successors according to CFG: BB#2(64) BB#4(21)
>
> Thanks,
> Weiming
>
> -----Original Message-----
> From: Renato Golin [mailto:renato.golin at linaro.org]
> Sent: Friday, October 30, 2015 8:30 AM
> To: Eric Christopher
> Cc: Weiming Zhao; LLVM Commits
> Subject: Re: [llvm] r251664 - Revert "[ARM] Remove XFAIL on
> test/CodeGen/Generic/MachineBranchProb.ll"
>
> On 30 October 2015 at 15:10, Eric Christopher via llvm-commits <
> llvm-commits at lists.llvm.org> wrote:
> > We prefer that you use the svn revision in the reversion message and
> > there's even a revert script that will do it for you
> > (utils/git-svn/git-svnrevert)
>
> Also, before committing an XFAIL/XPASS, please check the current
> buildbots. :)
>
> On a side note, I'd be interested to know why this pass to you and not the
> bots...
>
> cheers,
> --renato
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151030/5f9fe738/attachment.html>