[PATCH] D14187: [compiler-rt][aarch64] New tests for 128-bit floating-point builtins and fixes of tests

Sergey Dmitrouk via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 29 15:11:33 PDT 2015


sdmitrouk created this revision.
sdmitrouk added reviewers: rengolin, zatrazz, howard.hinnant, t.p.northover, jmolloy, enefaim.
sdmitrouk added a subscriber: llvm-commits.
sdmitrouk set the repository for this revision to rL LLVM.
Herald added subscribers: rengolin, aemerson.

The following tests for 128-bit floating-point type behaved in a strange way, thought it were bugs, but seem to be mistakes in tests:

 * `fixtfsi` test checked for `0x80000001` as a value returned for number less than can be represented, while `LONG_MIN` should be returned on saturation;
 * `fixunstfdi` wasn't enabled for AArch64, only for PPC, but there is nothing PPC specific in that test;
 * `multf3` tried to underflow multiplication by producing result with 16383 exponent, while there are still 112 bits of fraction plus implicit bit, so resultant exponent should be 16497.

Tests for some other builtins didn't exist:

 * `fixtfdi`
 * `fixtfti`
 * `fixunstfti`

They were made by copying similar files and adjusting for wider types and adding/removing some reasonable/extra checks.

Repository:
  rL LLVM

http://reviews.llvm.org/D14187

Files:
  test/builtins/Unit/fixtfdi_test.c
  test/builtins/Unit/fixtfsi_test.c
  test/builtins/Unit/fixtfti_test.c
  test/builtins/Unit/fixunstfdi_test.c
  test/builtins/Unit/fixunstfti_test.c
  test/builtins/Unit/multf3_test.c

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D14187.38767.patch
Type: text/x-patch
Size: 10021 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151029/fb66a6fb/attachment.bin>


More information about the llvm-commits mailing list