[llvm] r251655 - Fix test check label.

Teresa Johnson via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 29 14:24:39 PDT 2015


Author: tejohnson
Date: Thu Oct 29 16:24:38 2015
New Revision: 251655

URL: http://llvm.org/viewvc/llvm-project?rev=251655&view=rev
Log:
Fix test check label.

Summary:
I noticed when manually modifying this test that it was passing when I
expected it to fail. Looks like the combination of LABEL and NOT on the
check does not work. This can also be seen when running FileCheck with
only that one -check-prefix (removing the additional -check-prefix=B):

/usr/local/google/home/tejohnson/llvm/llvm_11_build/./bin/llvm-link -S -internalize -only-needed /usr/local/google/home/tejohnson/llvm/llvm_11_build/test/Linker/Output/link-flags.ll.tmp.b.bc /usr/local/google/home/tejohnson/llvm/llvm_11_build/test/Linker/Output/link-flags.ll.tmp.c.bc | /usr/local/google/home/tejohnson/llvm/llvm_11_build/./bin/FileCheck /usr/local/google/home/tejohnson/llvm/llvm_11/test/Linker/link-flags.ll -check-prefix=CN
error: no check strings found with prefix 'CN:'

The CN prefix checks don't in fact need "LABEL" so remove that.

Reviewers: tra

Subscribers: llvm-commits

Differential Revision: http://reviews.llvm.org/D14173

Modified:
    llvm/trunk/test/Linker/link-flags.ll

Modified: llvm/trunk/test/Linker/link-flags.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Linker/link-flags.ll?rev=251655&r1=251654&r2=251655&view=diff
==============================================================================
--- llvm/trunk/test/Linker/link-flags.ll (original)
+++ llvm/trunk/test/Linker/link-flags.ll Thu Oct 29 16:24:38 2015
@@ -9,7 +9,7 @@ C-LABEL: @X = global i32 5
 CI-LABEL: @X = internal global i32 5
 CU-LABEL:@U = global i32 6
 CI-LABEL:@U = internal global i32 6
-CN-LABEL-NOT:@U
+CN-NOT:@U
 
 B-LABEL: define void @bar() {
 
@@ -18,4 +18,4 @@ CI-LABEL: define internal i32 @foo()
 
 CU-LABEL:define i32 @unused() {
 CI-LABEL:define internal i32 @unused() {
-CN-LABEL-NOT:@unused()
+CN-NOT:@unused()




More information about the llvm-commits mailing list