[PATCH] D7802: [Inliner] Use whitelist instead of blacklist when checking function attribute compatibility and make the check stricter

Eric Christopher via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 29 13:49:08 PDT 2015


echristo accepted this revision.
echristo added a comment.

LGTM.

Thanks and sorry for the delay.

-eric


================
Comment at: include/llvm/IR/Attributes.h:69
@@ -121,1 +68,3 @@
+    #define GET_ATTR_ENUM
+    #include "llvm/IR/Attributes.inc"
     EndAttrKinds           ///< Sentinal value useful for loops
----------------
Can you separate this out into a separate patch? (Feel free to commit it as long as it's a nop change).


http://reviews.llvm.org/D7802





More information about the llvm-commits mailing list