[PATCH] D14128: Enable readobj to emit readelf like output.

khemant@codeaurora.org via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 29 10:17:01 PDT 2015


khemant added a comment.

My browser submitted the comment before completion. Apologies.
Here is complete comment:
What I have noticed is all enums are made to string as is in the LLVM style. However, GNU has different naming conventions such as "W"  instead of SHF_WRITE string as is. This will cause a lot of code bloat. An easy solution is to store GNU flavor of string with usuale string inside

  template<typename T>
  struct EnumEntry {
    StringRef Name;
    T Value;
  };

Any thoughts on this?


Repository:
  rL LLVM

http://reviews.llvm.org/D14128





More information about the llvm-commits mailing list