[PATCH] D14128: Enable readobj to emit readelf like output.

[Eric Christopher via llvm-commits]

echristo added a subscriber: echristo.
echristo added a comment.

I'm not necessarily against this, but I think the patch should be generic for all targets and I've highlighted an example of where it isn't. Instead of conditionals I think you might just want to abstract out the dumping mechanism as well.

Also, don't forget to add llvm-commits as a subscriber to your patch when you upload it so that email goes to the list right away.

-eric


================
Comment at: tools/llvm-readobj/ELFDumper.cpp:723
@@ -681,3 +722,3 @@
   LLVM_READOBJ_ENUM_ENT(ELF, EM_TRIMEDIA     ),
-  LLVM_READOBJ_ENUM_ENT(ELF, EM_HEXAGON      ),
+  {"Qualcomm Hexagon", ELF::EM_HEXAGON       },
   LLVM_READOBJ_ENUM_ENT(ELF, EM_8051         ),
----------------
Example...


Repository:
  rL LLVM

http://reviews.llvm.org/D14128