[PATCH] D14171: [ELF2] merge-string.s test fixed for win32 configuraton.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 29 09:36:16 PDT 2015


grimar added a comment.

Yes, I didn`t mean extreme cases like 4gb executables..
In short what I wanted to say is that storing size_t types is some kind of dangerous because behavior is depends on host type. So storing uint_x which is depends on target elf file is more safe and keeps behavior consistent here.
But honestly this issue really does not need so many attention.. let me just update the patch and lets just close it :)


http://reviews.llvm.org/D14171





More information about the llvm-commits mailing list