[PATCH] D14173: Fix test check label.

Teresa Johnson via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 29 06:15:34 PDT 2015


tejohnson created this revision.
tejohnson added a reviewer: tra.
tejohnson added a subscriber: llvm-commits.

I noticed when manually modifying this test that it was passing when I
expected it to fail. Looks like the combination of LABEL and NOT on the
check does not work. This can also be seen when running FileCheck with
only that one -check-prefix (removing the additional -check-prefix=B):

/usr/local/google/home/tejohnson/llvm/llvm_11_build/./bin/llvm-link -S -internalize -only-needed /usr/local/google/home/tejohnson/llvm/llvm_11_build/test/Linker/Output/link-flags.ll.tmp.b.bc /usr/local/google/home/tejohnson/llvm/llvm_11_build/test/Linker/Output/link-flags.ll.tmp.c.bc | /usr/local/google/home/tejohnson/llvm/llvm_11_build/./bin/FileCheck /usr/local/google/home/tejohnson/llvm/llvm_11/test/Linker/link-flags.ll -check-prefix=CN
error: no check strings found with prefix 'CN:'

The CN prefix checks don't in fact need "LABEL" so remove that.

http://reviews.llvm.org/D14173

Files:
  test/Linker/link-flags.ll

Index: test/Linker/link-flags.ll
===================================================================
--- test/Linker/link-flags.ll
+++ test/Linker/link-flags.ll
@@ -9,13 +9,13 @@
 CI-LABEL: @X = internal global i32 5
 CU-LABEL:@U = global i32 6
 CI-LABEL:@U = internal global i32 6
-CN-LABEL-NOT:@U
+CN-NOT:@U
 
 B-LABEL: define void @bar() {
 
 C-LABEL: define i32 @foo()
 CI-LABEL: define internal i32 @foo()
 
 CU-LABEL:define i32 @unused() {
 CI-LABEL:define internal i32 @unused() {
-CN-LABEL-NOT:@unused()
+CN-NOT:@unused()


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D14173.38726.patch
Type: text/x-patch
Size: 530 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151029/2458afc7/attachment.bin>


More information about the llvm-commits mailing list