[PATCH] D14140: [ELF2] SECTIONS command basic support

[Denis Protivensky via llvm-commits]

denis-protivensky marked 3 inline comments as done.

================
Comment at: ELF/Config.h:38
@@ +37,3 @@
+};
+
+struct OutputSectionDescription {
----------------
grimar wrote:
> May be regroup would look better ?
> 
> 
>   llvm::StringRef InputFile;
>   std::vector<llvm::StringRef> Names;
>   std::vector<llvm::StringRef> ExcludeFiles;
Ok, maybe.

================
Comment at: ELF/Writer.cpp:460
@@ +459,3 @@
+}
+
+template <class ELFT>
----------------
grimar wrote:
> What about next one ?
> 
> ```
>  if (!IS || !IS->isLive() || IS == &InputSection<ELFT>::Discarded)
>     return true;
> 
> return hasCustomSections() && InputToOutputSection.lookup(IS->getSectionName()) == "/DISCARD/";
> ```
A matter of taste again. Okay.

================
Comment at: ELF/Writer.cpp:910
@@ +909,3 @@
+        InputToOutputSection[Name] = OutSec.second.Name;
+}
+
----------------
grimar wrote:
> I think you want to use & after autos:
> auto &OutSec, auto &InSec ...
Yes, that's right.


http://reviews.llvm.org/D14140