[PATCH] D13989: This removes the eating of the error in Archive::Child::getSize() when the charactersin the size field in the archive header for the member is not a number.

[Kevin Enderby via llvm-commits]

enderby added a comment.

I agree with Lang and like the original patch where were were handling failure was done inside the iterator.  It does allow use of ranged-based for loops and appears to me much cleaner in the code especially in the lld changes needed in http://reviews.llvm.org/D13990 .

Rafael, I did "finish it up" based on your t.diff patch and that is below and includes the re-formatting with clang-format-diff, removal of the malformed-archives directory putting the .a files in Inputs and removal of the "nice but independent" changes.

F1026846: llvm_updated_t.diff <http://reviews.llvm.org/F1026846>

And here are the "finished up" corresponding changes that would be needed for lld:

F1026849: lld_updated_t.diff <http://reviews.llvm.org/F1026849>


http://reviews.llvm.org/D13989