[PATCH] D14046: [test-suite] Introduce a new CMake+LIT based harness

[Chris Bieneman via llvm-commits]

beanz added inline comments.

================
Comment at: cmake/modules/SingleMultiSource.cmake:139
@@ +138,3 @@
+  # Now do the actual configuration.
+  configure_file(${CMAKE_SOURCE_DIR}/cmake/lit-test-template.in
+    ${CMAKE_CURRENT_BINARY_DIR}/${exename}.test)
----------------
tra wrote:
> When test suite is configured as part of whole llvm+projects+clang tree CMAKE_SOURCE_DIR points to the top of the tree and there's no lit-test-template.in there. 
> 
> Perhaps you should use PROJECT_SOURCE_DIR here.
We should actually probably put a check in prohibiting building the test-suite in-tree. It doesn't work properly if you build it in-tree because it will use the system compiler not the just-built clang.


Repository:
  rL LLVM

http://reviews.llvm.org/D14046