[PATCH] D13801: [Support] Extend sys::path with user_cache_directory function.

[Rafael Ávila de Espíndola via llvm-commits]

rafael added inline comments.

================
Comment at: include/llvm/Support/Path.h:332
@@ +331,3 @@
+/// applications/services used by the user. At least an application/service name
+/// should be appended to the path before storing any files.
+///
----------------
Maybe take a twine argument and do the appending in here? It is easy to forget to read documentation :-).

================
Comment at: lib/Support/Unix/Path.inc:636
@@ -585,3 +635,3 @@
 
 void system_temp_directory(bool ErasedOnReboot, SmallVectorImpl<char> &Result) {
   Result.clear();
----------------
Should we drop the EraseOnReboot argument from this function? We would now have

 user_cache_directory
 system_temp_directory(true
 system_temp_directory(false

When should each one be used?


http://reviews.llvm.org/D13801