[PATCH] D14142: [2/4] Allow SP in rGPR, starting from ARMv8 (assembly)

Renato Golin via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 28 04:13:00 PDT 2015


rengolin added inline comments.

================
Comment at: test/MC/ARM/basic-thumb2-instructions-v8.s:27
@@ -26,1 +26,3 @@
 
+@ Can accept SP as rGPR
+        sbc.w r6, r3, sp, asr #16
----------------
tyomitch wrote:
> rengolin wrote:
> > ... in ARMv8 only
> Well, the test has "v8" in the filename, and "@ New ARMv8 T32 encodings" as the very first line, so naturally, all of the test cases are ARMv8-specific.
I know, but you're checking v7 in the same test...


http://reviews.llvm.org/D14142





More information about the llvm-commits mailing list