[PATCH] D14129: ELF2: Make .gnu.hash default instead of .hash.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 28 01:39:59 PDT 2015


grimar added inline comments.

================
Comment at: test/elf2/shared.s:284
@@ -283,3 +283,1 @@
 
-// CHECK:      HashTable {
-// CHECK-NEXT:   Num Buckets: 4
----------------
ikudrin wrote:
> ruiu wrote:
> > grimar wrote:
> > > Was the next part of test removed intentionaly ?
> > > 
> > > // CHECK:      HashTable {
> > > // CHECK-NEXT:   Num Buckets: 4
> > > // CHECK-NEXT:   Num Chains: 4
> > > // CHECK-NEXT:   Buckets: [3, 0, 2, 0]
> > > // CHECK-NEXT:   Chains: [0, 0, 0, 1]
> > > // CHECK-NEXT: }
> > This is intentional.
> It looks like we now have no tests which check HashTable section. I'd suggest to add -hash-style=sysv command line switch at least for this test case.
May be would be better to add another test in another patch for testing hashtable sections then ?


http://reviews.llvm.org/D14129





More information about the llvm-commits mailing list