[PATCH] D13659: Implement .reloc (constant offset only) with support for R_MIPS_NONE and R_MIPS_32.

[David Majnemer via llvm-commits]

majnemer added subscribers: rafael, grosbach.
majnemer added a comment.

Thanks for quickly working through the feedback :)

This LGTM but I'd be more comfortable with somebody else concurring, perhaps @grosbach or @rafael.


================
Comment at: lib/MC/MCObjectStreamer.cpp:446
@@ +445,3 @@
+  MCFixupKind Kind;
+  if (Assembler->getBackend().getFixupKind(Name, Kind)) {
+    if (Expr == nullptr)
----------------
You could reduce indentation by returning `true` if `getFixupKind` fails.


http://reviews.llvm.org/D13659