[llvm] r251486 - [SelectionDAG] Don't inspect !range metadata for extended loads

[Sanjoy Das via llvm-commits]

Author: sanjoy
Date: Tue Oct 27 22:20:10 2015
New Revision: 251486

URL: http://llvm.org/viewvc/llvm-project?rev=251486&view=rev
Log:
[SelectionDAG] Don't inspect !range metadata for extended loads

Summary:
Don't call `computeKnownBitsFromRangeMetadata` for extended loads --
this can cause a mismatch between the width of the !range metadata and
the width of the APInt's accumulating `KnownZero` (and `KnownOne` in the
future).  This isn't a problem now, but will be after a future change.

Note: this can be made more aggressive in the future.

Reviewers: nlewycky

Subscribers: llvm-commits

Differential Revision: http://reviews.llvm.org/D14107

Added:
    llvm/trunk/test/CodeGen/PowerPC/selectiondag-extload-computeknownbits.ll
Modified:
    llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAG.cpp

Modified: llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAG.cpp?rev=251486&r1=251485&r2=251486&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAG.cpp (original)
+++ llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAG.cpp Tue Oct 27 22:20:10 2015
@@ -2284,7 +2284,8 @@ void SelectionDAG::computeKnownBits(SDVa
       unsigned MemBits = VT.getScalarType().getSizeInBits();
       KnownZero |= APInt::getHighBitsSet(BitWidth, BitWidth - MemBits);
     } else if (const MDNode *Ranges = LD->getRanges()) {
-      computeKnownBitsFromRangeMetadata(*Ranges, KnownZero);
+      if (LD->getExtensionType() == ISD::NON_EXTLOAD)
+        computeKnownBitsFromRangeMetadata(*Ranges, KnownZero);
     }
     break;
   }

Added: llvm/trunk/test/CodeGen/PowerPC/selectiondag-extload-computeknownbits.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/PowerPC/selectiondag-extload-computeknownbits.ll?rev=251486&view=auto
==============================================================================
--- llvm/trunk/test/CodeGen/PowerPC/selectiondag-extload-computeknownbits.ll (added)
+++ llvm/trunk/test/CodeGen/PowerPC/selectiondag-extload-computeknownbits.ll Tue Oct 27 22:20:10 2015
@@ -0,0 +1,12 @@
+; RUN: llc -mtriple=powerpc64-bgq-linux < %s
+
+; Check that llc does not crash due to an illegal APInt operation
+
+define i1 @f(i8* %ptr) {
+ entry:
+  %val = load i8, i8* %ptr, align 8, !range !0
+  %tobool = icmp eq i8 %val, 0
+  ret i1 %tobool
+}
+
+!0 = !{i8 0, i8 2}