[PATCH] D13659: Implement .reloc (constant offset only) with support for R_MIPS_NONE and R_MIPS_32.

Daniel Sanders via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 27 19:01:56 PDT 2015


dsanders added inline comments.

================
Comment at: lib/MC/MCParser/AsmParser.cpp:4611-4614
@@ +4610,6 @@
+
+  // We can only deal with constant expressions at the moment.
+  int64_t OffsetValue;
+  if (!Offset->evaluateAsAbsolute(OffsetValue))
+    return Error(OffsetLoc, "expression is not a constant value");
+
----------------
Do you know any cases where the addend isn't supported? The GAS documentation says that ELF REL targets such as 386 don't support addends but I'm finding they work. Similarly, addends are also working for MIPS O32 which is also a REL target.


http://reviews.llvm.org/D13659





More information about the llvm-commits mailing list