[PATCH] D14038: SelectionDAG: Match min/max if the scalar operation is legal

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 27 13:18:19 PDT 2015


arsenm added a comment.

In http://reviews.llvm.org/D14038#276523, @hfinkel wrote:

> Can you please explain the logic behind this change?


This min/max pattern matching is weird because it's done in SelectionDAGBuilder. It won't match for any vector if the vector operation isn't legal. AMDGPU only has vector loads and stores, and every operation is scalar, so we only care about the legality of the scalar operations.


http://reviews.llvm.org/D14038





More information about the llvm-commits mailing list