[PATCH] D14120: instruction 'align' in asm blocks works incorrectly with some cases of parameters clean revision

Reid Kleckner via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 27 09:39:55 PDT 2015


rnk added inline comments.

================
Comment at: test/CodeGen/ms-inline-asm.c:294-299
@@ -293,8 +293,2 @@
   __asm align 8
-// CHECK: .align 3
-  __asm align 16;
-// CHECK: .align 4
-  __asm align 128;
-// CHECK: .align 7
-  __asm ALIGN 256;
 // CHECK: .align 8
----------------
m_zuckerman wrote:
> Incorrect lowering of the align N for Darwin The running mode is 
> // RUN: %clang_cc1 %s -triple i386-apple-darwin10 -fasm-blocks -emit-llvm -o - | FileCheck %s
I don't think this is incorrect. This appears to be our fundamental disagreement. Please review my comments from earlier about how this should work.


http://reviews.llvm.org/D14120





More information about the llvm-commits mailing list