Re: [PATCH] D12399: Microsoft compatibility – add support for “relaxation” of memory operands in inline assembly.

[David Majnemer via llvm-commits]

majnemer added inline comments.

================
Comment at: lib/Target/X86/AsmParser/X86AsmParser.cpp:2670-2672
@@ +2669,5 @@
+  uint64_t ErrorInfoIgnore;
+  // We are doing relaxcation only for microsoft OS.
+  // This will work only with triple -x86-64-pc-windows-msvc
+  bool RelaxcationMode = STI.getTargetTriple().getOS() == STI.getTargetTriple().Win32; 
+  unsigned M = MatchInstructionImpl(Operands, MInst, ErrorInfoIgnore,
----------------
Would it make more sense to predicate this on whether or not we are doing inline assembly instead of whether or not our OS is Windows?


http://reviews.llvm.org/D12399