[PATCH] D13989: This removes the eating of the error in Archive::Child::getSize() when the charactersin the size field in the archive header for the member is not a number.

[Rafael Espíndola via llvm-commits]

I applied the patch and I am currently reviewing it.

Two quick things I noticed:
* The formatting is odd, please git-clang-format the patch.
* Adding the malformed-archives directory seems premature, just put
the .a in Inputs.


On 26 October 2015 at 12:58, Kevin Enderby <enderby at apple.com> wrote:
> enderby updated this revision to Diff 38452.
> enderby added a comment.
>
> Sorry my tree was a bit out of date and was showing diffs in tools/llvm-objdump/MachODump.cpp that were in r251215 that Rafael did to Simplify boolean expressions in tools/llvm-objdump.  Sorry about that.
>
>
> http://reviews.llvm.org/D13989
>
> Files:
>   include/llvm/Object/Archive.h
>   include/llvm/Support/ErrorOr.h
>   lib/ExecutionEngine/MCJIT/MCJIT.cpp
>   lib/ExecutionEngine/Orc/OrcMCJITReplacement.h
>   lib/Object/Archive.cpp
>   lib/Object/ArchiveWriter.cpp
>   test/tools/llvm-objdump/Inputs/malformed-archives/libbogus1.a
>   test/tools/llvm-objdump/Inputs/malformed-archives/libbogus2.a
>   test/tools/llvm-objdump/Inputs/malformed-archives/libbogus3.a
>   test/tools/llvm-objdump/malformed-archives.test
>   tools/dsymutil/BinaryHolder.cpp
>   tools/llvm-ar/llvm-ar.cpp
>   tools/llvm-cxxdump/llvm-cxxdump.cpp
>   tools/llvm-nm/llvm-nm.cpp
>   tools/llvm-objdump/MachODump.cpp
>   tools/llvm-objdump/llvm-objdump.cpp
>   tools/llvm-readobj/llvm-readobj.cpp
>   tools/llvm-size/llvm-size.cpp
>