[PATCH] D13255: [LAA] LLE 2/6: Fix a NoDep case that should be a Forward dependence

Adam Nemet via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 26 20:10:34 PDT 2015


anemet added a comment.

In http://reviews.llvm.org/D13255#275197, @rengolin wrote:

> IIUC, this new dependency analysis won't trigger anything in the compiler to change its behaviour, so even if the analysis is not complete yet (and need an extra dep to trigger the memory check), it still shouldn't break any existing code. Is that correct?


Correct.

> I wonder if this could be squashed into some future commit (3rd~6th) to avoid the weird comments on the test case, even if temporary. But it's not a big deal, since no one will be crazy enough to pick a stable master where the head is "[2/6]" of some patch. :)


Not really.  Unfortunately it's not trivial to fix this (it probably will be another patchset with some compile time measurement) and it's not required for LLE (as I explain in that patch) so my preference would be to keep outside this set and then get back to it ASAP.

> As long as it doesn't break any bot (which I doubt it will), this should be fine, too.


Thanks, Renato!


http://reviews.llvm.org/D13255





More information about the llvm-commits mailing list