[PATCH] D14094: Add multikey_qsort to STLExtras.h

[David Blaikie via llvm-commits]

On Mon, Oct 26, 2015 at 3:36 PM, Rui Ueyama <ruiu at google.com> wrote:

> On Mon, Oct 26, 2015 at 3:29 PM, David Blaikie <dblaikie at gmail.com> wrote:
>
>>
>>
>> On Mon, Oct 26, 2015 at 3:26 PM, Sean Silva via llvm-commits <
>> llvm-commits at lists.llvm.org> wrote:
>>
>>> silvas added a subscriber: silvas.
>>> silvas added a comment.
>>>
>>> I'd really like to see sanity check performance numbers vs. std::sort to
>>> make sure that this function is worth it.
>>>
>>
>> +1 - wouldn't mind seeing some more data on the options here. Not that
>> this piece of code is terribly costly to add & I can totally understand why
>> a linker would need a sort algorithm specifically designed to cope with
>> inputs with large common prefixes.
>>
>
> I guess a more important question is how useful this function is in
> general. Is there any places in LLVM or Clang that we want to use this?
>

I'm probably not the most qualified to answer, but for myself I don't know
of anything that comes particularly to mind. Maybe in LTO linking for the
same reason - finding matching functions by name (with the same kind of
prefix problems as LLD).

I don't mind it being in LLVM though - could possibly use some direct unit
tests (or maybe the testing via StringTableBuilder is good enough?)?


>
>
>>>
>>> http://reviews.llvm.org/D14094
>>>
>>>
>>>
>>> _______________________________________________
>>> llvm-commits mailing list
>>> llvm-commits at lists.llvm.org
>>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>>>
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151026/30164d74/attachment.html>