[PATCH] D14095: Use Twin instead of std::to_string

Mehdi AMINI via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 26 15:30:30 PDT 2015


joker.eph added inline comments.

================
Comment at: lib/Bitcode/Reader/BitcodeReader.cpp:3118
@@ -3118,2 +3117,3 @@
+        auto CurrentEpoch = Twine(bitc::BITCODE_CURRENT_EPOCH);
         return error(Twine("Incompatible epoch: Bitcode '") + BitcodeEpoch +
                      "' vs current: '" + CurrentEpoch + "'");
----------------
jroelofs wrote:
> Drop the temporaries while you're at it:
> 
>     return error(Twine("Incompatible epoch: Bitcode '") + epoch +
>                  "' vs current: '" + bitc::BITCODE_CURRENT_EPOCH + "'");
+1, I wish I knew Twine accepts this :)


http://reviews.llvm.org/D14095





More information about the llvm-commits mailing list