[PATCH] D14046: [test-suite] Introduce a new CMake+LIT based harness

[Chris Bieneman via llvm-commits]

beanz added a comment.

Thank you for doing this! This looks like a great start to get the ball rolling!


================
Comment at: CMakeLists.txt:1
@@ +1,2 @@
+cmake_minimum_required(VERSION 2.8.12.2)
+
----------------
Do we need to make this 2.8.12.2? If we make it 3.2 then we can fold away some of the later version checks and features, and since this is a new CMake build system I'd kinda like to have it ditch support for legacy versions.

================
Comment at: cmake/modules/SingleMultiSource.cmake:161
@@ +160,3 @@
+      append_ldflags(${source_exename} LDFLAGS)
+      llvm_add_test(${name} ${source_exename})
+    endif()
----------------
Probably need to add something like this `add_dependencies(${source_exename} timeit fpcmp)` here.

================
Comment at: cmake/modules/SingleMultiSource.cmake:189
@@ +188,3 @@
+    append_ldflags(${source_exename} LDFLAGS)
+    llvm_add_test(${PROG} ${source_exename})
+  endif()
----------------
Same as above.


Repository:
  rL LLVM

http://reviews.llvm.org/D14046