[PATCH] D14053: Optimize StringTableBuilder

[Jim Grosbach via llvm-commits]

grosbach added a subscriber: grosbach.
grosbach added a comment.

Cool. AFAIK, the only reason for the array_pod_sort() before was "seems good enough for now."


================
Comment at: lib/MC/StringTableBuilder.cpp:33
@@ +32,3 @@
+// because it does not compare characters that we already know the same.
+static void qsort(StringPair **Begin, StringPair **End, int Pos) {
+tailcall:
----------------
Can we use a different name? Function names that collide with the C standard library are bountiful opportunities for confusion later.

Relatedly, perhaps this helper function, or a generalized version of it, should go into STLExtras.h next to array_pod_sort?


http://reviews.llvm.org/D14053