[PATCH] D14084: [ELF2] Move sorting from symbol table to the GNU hash section.

Igor Kudrin via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 26 12:17:06 PDT 2015


ikudrin added inline comments.

================
Comment at: ELF/OutputSections.cpp:349
@@ -351,2 +348,3 @@
 template <class ELFT> void GnuHashTableSection<ELFT>::writeTo(uint8_t *Buf) {
+  assert(NumHashed == HashedSymbols.size() && "sortSymbols() was not called!");
   writeHeader(Buf);
----------------
The variable is required in the finalize() method. The HashedSymbols is filled in the sortSymbols() method, which is called from finalize() method of the dynamic symbol table. All finalize() methods should not depend on each other and their call order, I think.


http://reviews.llvm.org/D14084





More information about the llvm-commits mailing list