[PATCH] D14084: [ELF2] Move sorting from symbol table to the GNU hash section.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 26 11:22:14 PDT 2015


ruiu added inline comments.

================
Comment at: ELF/OutputSections.h:298
@@ -306,3 +297,3 @@
   void writeTo(uint8_t *Buf) override;
-
-  static unsigned calcNBuckets(unsigned NumHashed);
+  void addSymbol(SymbolBody *Body) { ++NumHashed; }
+  // Update the order of dynamic symbol section symbols
----------------
This looks really weird. You are not using the argument.


http://reviews.llvm.org/D14084





More information about the llvm-commits mailing list