[PATCH] D13998: Move parts of llvm-symbolizer tool into LLVMSymbolize library.

[Alexey Samsonov via llvm-commits]

samsonov added a comment.

Thanks!


================
Comment at: lib/DebugInfo/Symbolize/Symbolize.cpp:14
@@ -13,2 +13,3 @@
 
-#include "LLVMSymbolize.h"
+#include "llvm/DebugInfo/Symbolize/Symbolize.h"
+
----------------
echristo wrote:
> Should be down with the other headers?
http://llvm.org/docs/CodingStandards.html#main-module-header

================
Comment at: lib/DebugInfo/Symbolize/Symbolize.cpp:49
@@ -47,2 +48,3 @@
 
+// FIXME: Move this to llvm-symbolizer tool.
 static bool error(std::error_code ec) {
----------------
echristo wrote:
> Please do :)
I'll do it in a follow-up changes: for now LLVMSymbolizer doesn't know how to return errors to the user, and it would take some refactoring to achieve that - let's keep this change a relatively straightforward code move.


http://reviews.llvm.org/D13998