[PATCH] D14067: [FPEnv Core 02/14] Add FPEnv access flags to fast-math flags

Steve Canon via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 26 08:59:15 PDT 2015


scanon added a comment.

In http://reviews.llvm.org/D14067#275220, @majnemer wrote:

> I'd like to propose a mildly different design; I'd phrase the two flags using a positive perspective:
>
> - `nexc`: Assume that floating-point exceptions are not relevant.
> - `nrnd`: Assume that the rounding-mode is round-to-nearest (ties even).
>
>   This has the nice property that `fast` is the union of all flags and, in general, keeps things consistent with all the other fast math flags.  The general pattern is that adding flags permits further optimization; places where this is violated have been a wellspring of bugs (namely `volatile`).


I like this ("observed" instead of "relevant", perhaps).


Repository:
  rL LLVM

http://reviews.llvm.org/D14067





More information about the llvm-commits mailing list