[PATCH] D14067: [FPEnv Core 02/14] Add FPEnv access flags to fast-math flags

Steve Canon via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 26 08:12:04 PDT 2015


scanon added inline comments.

================
Comment at: docs/LangRef.rst:1921
@@ +1920,3 @@
+   Keep Exceptions - Forbid optimizations to affect floating-point exceptions
+   that can be thrown at runtime.
+
----------------
Let's avoid "thrown", which tends to conjure an entirely different notion of "exception".  The IEEE-754 nomenclature is "raised".

================
Comment at: docs/LangRef.rst:1930
@@ -1921,3 +1929,3 @@
    dramatically change results in floating point (e.g. reassociate). This
-   flag implies all the others.
+   flag implies all the others except for the last two.
 
----------------
It should explicitly imply that `kexc` and `kround` are *not set*.


Repository:
  rL LLVM

http://reviews.llvm.org/D14067





More information about the llvm-commits mailing list