HA: [lld] r251144 - [ELF2] --strip-all/-s command line implemented

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Sat Oct 24 15:52:51 PDT 2015


>От: Rui Ueyama [ruiu at google.com]
>Отправлено: 24 октября 2015 г. 1:12
>Кому: George Rimar
>Копия: llvm-commits
>Тема: Re: [lld] r251144 - [ELF2] --strip-all/-s command line implemented
>
>Rolled back the change in r251148. Please re-submit with a fix. Thanks!

Thank you, Rui,
I reapplied the patch in r251184.

Actually problem was that llvm-mc created %t:
# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t

but second and third check used %t.o as input, eg:
#RUN: ld.lld2 %t.o -e main --strip-all -o %t1

And on my machine tests were passed because I had %t.o from previous version of test.
And build bot didn`t have it and failed.

That makes me think about possible improvement of testing system, like making
unique names for temp files for each test run. Not sure if that problem from above can happen for build bot (hope it removes
temp files or do something another like checkout to clear folder to avoid that), but it happens for local tests sometimes.


More information about the llvm-commits mailing list