[PATCH] D9986: Refactor: Simplify boolean conditional return statements in lib/Target/SystemZ
Richard via llvm-commits
llvm-commits at lists.llvm.org
Sat Oct 24 14:08:01 PDT 2015
LegalizeAdulthood added a comment.
In http://reviews.llvm.org/D9986#201999, @uweigand wrote:
> Some of these changes make sense to me, but a number of others don't appear to make the code more readable.
>
> The latter are typically of the form:
>
> if (cond1)
> return false;
> if (cond2)
> return false;
> ...
> if (condN)
> return false;
>
> return true;
>
>
> In a sequence like this (which is written this way to be able to easily add/remove further conditions as appropriate, it doesn't really improve maintainability to just transform the *last* condition.
This should not be a problem anymore.
http://reviews.llvm.org/D9986
More information about the llvm-commits
mailing list